-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quickstart tests by updating Node version #1214
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
We use 12.20 in other parts of the CI process b/c certain development dependencies require it (Jest, IIRC), but we test against 10.0.0 here because that's the minimum Node version the library supports.
The minimum version is actually 12.20 according to the README. It's necessary because the Node quickstart test was failing on 10.0. |
c83dfe2
to
c55de79
Compare
That's the minimum version in order to work on the JS language library; the minimum Node.js version for installing the built
Why were the quickstart tests failing on 10.0.0? |
a6be194
to
43236bb
Compare
43236bb
to
1868895
Compare
.github/workflows/publish.yml
Outdated
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.20.0 | ||
node-version: 10.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not consequential here, but a general note: I think YAML removes trailing .0
s from numbers, so this will actually get parsed as 10.24
and the latest version that matches 10.24.x
will be installed instead of 10.24.0
.
No description provided.