Throw an error if the attribute is truly undefined #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@gj what do you think? This would be a breaking change. Do you think anyone would depend on the old behaviour? |
gj
reviewed
Sep 21, 2021
but yeah I think it's a good change that we should make |
Co-authored-by: Gabe Jackson <17556281+gj@users.noreply.github.com>
gj
reviewed
Sep 21, 2021
Co-authored-by: Gabe Jackson <17556281+gj@users.noreply.github.com>
Co-authored-by: Gabe Jackson <17556281+gj@users.noreply.github.com>
gj
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiates between
{x: undefined}.x = yand{}.x = y. The former is fine withy = undefined, the latter raises an error.Fixes #749
Discussed this approach with @gj a few weeks back. Check for the attribute with
"x" in d.