Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype fixes for pardiso #487

Merged
merged 1 commit into from Jan 23, 2023
Merged

Conversation

bnaras
Copy link
Contributor

@bnaras bnaras commented Nov 9, 2022

The R interface required these prototype fixes (among a few others) as CRAN enables prototype checks. Reference: https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521/20

The fixes here are very trivial.

The R interface required these prototype fixes (among a few others) as CRAN enables prototype checks.  Reference: https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521/20

The fixes here are very trivial.
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3432777756

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.033%

Totals Coverage Status
Change from base Build 3070562604: 0.0%
Covered Lines: 1868
Relevant Lines: 2052

💛 - Coveralls

@imciner2
Copy link
Member

imciner2 commented Nov 16, 2022

@vineetbansal the MKL tests for master seem to be having trouble loading the library now. The master branch still loads MKL manually, so it looks in a few places, the error it gives is:

ERROR in lh_load_lib: Error while loading dynamic library libmkl_rt.dylib: dlopen(libmkl_rt.dylib, 0x0001): tried: 'libmkl_rt.dylib' (no such file), '/usr/local/lib/libmkl_rt.dylib' (no such file), '/usr/lib/libmkl_rt.dylib' (no such file), '/Users/runner/work/osqp/osqp/libmkl_rt.dylib' (no such file)

Does conda install the library in any of those places, or is there somewhere else it puts it?

@bnaras
Copy link
Contributor Author

bnaras commented Jan 16, 2023

Can this PR be acted upon? Else I am forced to keep patching up the R interface indefinitely! Thank you.

@vineetbansal vineetbansal merged commit e3e338a into osqp:master Jan 23, 2023
@vineetbansal
Copy link
Contributor

Hi @bnaras, @imciner2 - I'm merging this PR because the changes are trivial and correct. What was holding this PR back was failing tests on macos-latest, for which there is a dedicated PR #490. I'll keep that open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants