Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running CI on macos-11 + macos-latest #490

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Running CI on macos-11 + macos-latest #490

merged 3 commits into from
Mar 30, 2023

Conversation

vineetbansal
Copy link
Contributor

To see if its a macos-12 issue

To see if its a macos-12 issue
@coveralls
Copy link

coveralls commented Nov 17, 2022

Pull Request Test Coverage Report for Build 4555813876

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 90.835%

Files with Coverage Reduction New Missed Lines %
lin_sys/direct/qdldl/qdldl_interface.c 2 94.19%
src/polish.c 2 79.2%
src/auxil.c 4 96.17%
Totals Coverage Status
Change from base Build 3070562604: -0.2%
Covered Lines: 1903
Relevant Lines: 2095

💛 - Coveralls

correct cmake_generator for macos-11
@vineetbansal
Copy link
Contributor Author

All tests on macos-11 are working. It seems like its an XCode 14 error on the latest macos image, as per actions/runner-images#6350.

We could try to use macos-latest and downgrade XCode as per:
actions/runner-images#6350 (comment)

or alternatively, pin to macos-11 for now?

@vineetbansal
Copy link
Contributor Author

I've pinned the CI to macos 11 for now. Perhaps we can open up an issue to move to macos-latest (the failures on which have nothing to do with our code AFAIK).

@imciner2 imciner2 merged commit 8461921 into master Mar 30, 2023
@imciner2 imciner2 deleted the vb/ci-macos branch March 30, 2023 09:54
@imciner2
Copy link
Member

Is macOS 11+ support an issue on the develop-1.0 branch? I think this has to do with how we are linking the MKL library file, which changed in the upcoming version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants