Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leak using ConvertStringSidToSid in Windows users table #6979

Closed
Breakwell opened this issue Mar 1, 2021 · 2 comments · Fixed by #6984
Closed

Leak using ConvertStringSidToSid in Windows users table #6979

Breakwell opened this issue Mar 1, 2021 · 2 comments · Fixed by #6984
Assignees
@mike-myers-tob
Labels
bug virtual tables Windows

Comments

@Breakwell
Copy link
Contributor

Breakwell commented Mar 1, 2021 •
edited

I originally reported #6560 for a leak around this sid. Looks like the LocalFree was removed in this change: #6782

Should we consider putting the Windows user SID code in some kind of RAAI class?
@theopolis theopolis added the bug label Mar 1, 2021
@theopolis
Copy link
Member

Heads up @mike-myers-tob

@mike-myers-tob mike-myers-tob self-assigned this Mar 2, 2021
@mike-myers-tob
Copy link
Member

Ah! Those two PRs were around the same time, and maybe I didn't pick up the change correctly. I'll open another quick PR to fix this.

Should we consider putting the Windows user SID code in some kind of RAAI class?

It's a good idea, but I'd have to ask someone else, right now I can't make the time to refactor the Windows code

@mike-myers-tob mike-myers-tob mentioned this issue Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-myers-tob mike-myers-tob

Labels
bug virtual tables Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mem leak regression with Windows' sids API trailofbits/osquery
3 participants
@theopolis @mike-myers-tob @Breakwell