Tightening up the eventing publisher #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
theopolis
requested changes
Nov 9, 2017
osquery/events/darwin/event_taps.cpp
Outdated
| EventFactory::fire<EventTappingEventPublisher>(ec); | ||
| return event; | ||
| EventFactory::fire<EventTappingEventPublisher>(createEventContext()); | ||
| /// If you change from listenOnly, return event or you will drop all events |
osquery/events/darwin/event_taps.cpp
Outdated
| CFRunLoopRemoveSource(run_loop_, run_loop_source_, kCFRunLoopCommonModes); | ||
| CFRelease(run_loop_source_); | ||
| run_loop_source_ = nullptr; | ||
| if (runLoopSource_ != nullptr) { |
There was a problem hiding this comment.
You should use snake case for local member variables, but we don't enforce it.
osquery/events/darwin/event_taps.cpp
Outdated
| kCGEventTapOptionListenOnly, | ||
| (1 << kCGEventKeyDown), | ||
| eventCallback, | ||
| NULL); |
osquery/events/darwin/event_taps.cpp
Outdated
| run_loop_ = nullptr; | ||
|
|
||
| if (eventTap_ != nullptr) { | ||
| CGEventTapEnable(eventTap_, false); |
There was a problem hiding this comment.
Should you do this "disable" before removing the source? Not sure, just curious?
obelisk
force-pushed
the
eventTapTightening
branch
from
6bf2afa
to
2dd3222
Compare
|
@obelisk has updated the pull request. |
obelisk
force-pushed
the
eventTapTightening
branch
from
2dd3222
to
5c8e5cf
Compare
|
@obelisk has updated the pull request. |
obelisk
force-pushed
the
eventTapTightening
branch
from
5c8e5cf
to
2ae754f
Compare
|
@obelisk has updated the pull request. |
theopolis
added
events
theopolis
approved these changes
Nov 9, 2017
trizt
pushed a commit
to trizt/osquery
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten up the event tapping event publisher code. This should hopefully make the code more stable and better equip it to handle edge cases.