Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/certificates: Improve table's coverage of Personal certificates #5640

Merged

Commits on Jul 16, 2019

  1. Make Personal certs visible for other users

    They aren't returned by the cert enumeration APIs, but if we
    directly look into their %APPDATA%, we can find them. The files
    there are a custom file format, which we can parse to extract the
    actual encoded certificate. We can then forward that back to the
    winapi to extract info out of it.
    
    We can also proactively look for them on disk, regardless of the
    enumeration, which will guarantee that we will always be able to show
    Personal certs regardless of things like, e.g. login history. For
    example, if a user has never logged in on a system since boot, they may
    not appear in the registry, and thus the enumeration, so their Personal
    certs will not appear, even though they are available.
    offlinemark committed Jul 16, 2019
    Copy the full SHA
    fe5aa82 View commit details
    Browse the repository at this point in the history
  2. Do not fetch from disk if we didn't get a username

    It would safely fail before with a file not found error, but this is
    more explicit.
    offlinemark committed Jul 16, 2019
    Copy the full SHA
    5187204 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a5dad00 View commit details
    Browse the repository at this point in the history
  4. Properly pack push/pop

    offlinemark committed Jul 16, 2019
    Copy the full SHA
    17b77d6 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    36713a0 View commit details
    Browse the repository at this point in the history
  6. Make args const

    offlinemark committed Jul 16, 2019
    Copy the full SHA
    4d20e86 View commit details
    Browse the repository at this point in the history
  7. Rm old comment

    offlinemark committed Jul 16, 2019
    Copy the full SHA
    b33d56c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Copy the full SHA
    a009e39 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a7bcbd4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    9283423 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    a81bfe4 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    da5abca View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    30f9d77 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    7ab84d4 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    b0ce099 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    109c2b1 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    49236fd View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    c116dd4 View commit details
    Browse the repository at this point in the history
  12. Fix formatting

    offlinemark committed Jul 22, 2019
    Copy the full SHA
    ceb89ec View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Copy the full SHA
    3ab4359 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6e156c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Copy the full SHA
    76446da View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    65f30b9 View commit details
    Browse the repository at this point in the history
  3. Make comment single line

    offlinemark committed Aug 5, 2019
    Copy the full SHA
    1c640cb View commit details
    Browse the repository at this point in the history
  4. Use more precise internal query

    Similar to the user_groups table, we filter out some of the accounts we
    know will not have directories on disk for certificates
    offlinemark committed Aug 5, 2019
    Copy the full SHA
    dbd94cb View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Use getUserHomeDir to construct Personal certs path

    Previously, we assumed a certain path structure for where to find a
    user's Personal certificates. Now we reuse some functionality from the
    users table which checks the registry to retrieve the home directory.
    offlinemark committed Aug 6, 2019
    Copy the full SHA
    6960cfe View commit details
    Browse the repository at this point in the history
  2. Expand environment variables in home dir string

    For system accounts (e.g. Local System) the home dir paths we get back
    from getUserHomeDir may contain environment variables. This expands them
    so we can now retrieve certificates within certificate directories for
    system accounts.
    offlinemark committed Aug 6, 2019
    Copy the full SHA
    ee353b1 View commit details
    Browse the repository at this point in the history
  3. Update buck build

    offlinemark committed Aug 6, 2019
    Copy the full SHA
    ac2db38 View commit details
    Browse the repository at this point in the history