Upgrade Python tools to Python3 #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mike-myers-tob
added
build
macOS Catalina
adhaamehab
force-pushed
the
master
branch
5 times, most recently
from
cd3246b
to
e59a81e
Compare
theopolis
reviewed
Oct 3, 2019
adhaamehab
changed the title
|
@theopolis apparently the failed checks are issue with |
|
Thanks for the work here, do you mind rebasing onto master to fix the CI false positive? |
I can trigger the rebase too apparently. |
and remove codegen files
|
@theopolis I think this is now ready for review whenever you have time! |
theopolis
approved these changes
Oct 5, 2019
muffins
pushed a commit
to muffins/osquery
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in progress PR
This PR fixes #5762
Note: Commits will be squashed after all the changes are done!
The Python shebang lines should be #!/usr/bin/env python3 unless the code is compatible with both Python 2.x and 3.x. If our script says it requires Python2 but the shebang line just says python, it will fail if the system resolves that to Python 3.
Python in the osquery build and test systems:
osquery/tools/analysis/*
osquery/tools/build_defs/oss/osquery/*
osquery/tools/codegen/*
osquery/tools/deployment/*
osquery/tools/get_platform.py
osquery/tools/hooks/pre_commit.py
osquery/tools/tests/*
osquery/tools/cmake/downloader.py
osquery/tools/formatting/*