Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build openssl with the macOS SDK version taken from CMake #6469

Merged

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented May 28, 2020

No description provided.

@Smjert Smjert added macOS libraries For things referring to osquery third party libraries labels May 28, 2020
@theopolis theopolis merged commit 03cf733 into osquery:master May 28, 2020
@theopolis
Copy link
Member

Hmm, we might have to set this to a default within CMake to prevent compile errors.

@Smjert
Copy link
Member Author

Smjert commented May 29, 2020

Hmm, we might have to set this to a default within CMake to prevent compile errors.

You're right, I got sloppy, I was under the impression that the variable would be automatically set to the value CMake detected if not explicitly set, but it's not like that.
When it takes the default is empty, so we shouldn't pass the compiler option at all in that case, since then the default for the compiler used will be chosen.

I'll open a PR.

@Smjert Smjert deleted the stefano/libs/openssl-macos-sdk branch June 26, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries For things referring to osquery third party libraries macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants