Aptsources #6482
Aptsources #6482
Conversation
|
|
i went and input the data for easy cla, but I'm not sure how to clear the blocker |
|
I opened a support ticket with a request for help on the error mentioned:
I am guessing the PR and EasyCLA check is having trouble identifying your GitHub username. I'll wait for guidance from EasyCLA. |
|
The EasyCLA error is probably because the indivual commits are coming in with an email address different than the one you signed the CLA with. This turns out to be quite common. If you have an unconfigured machine, you'll get some local email address, which github doesn't recognize, and thus neither does EasyCLA. Rebasing / squashing everything into a known email address should fix it, |
…0 to master * commit 'eeee0fb0957f5af983f817c2e6f19c53108d9e09': (83 commits) Add additional changelog items (osquery#6523) Changelog for 4.4.0 (osquery#6492) build: Add Azure tables to specs CMakeLists (osquery#6507) CMake: Correct macOS framework linking (osquery#6522) tables: Only populate table cache with star-like selects (osquery#6513) CMake: Fix and cleanup compile flags (osquery#6521) docs: Add note to bump the Homebrew cask (osquery#6519) tests: Fix atom_packages, processes, rpm_packages flakiness (osquery#6518) bug: Do not use system proxy for AWS local authority (osquery#6512) packaging: updating docs on cpack usage to include Chocolatey (osquery#6022) bug: Fix typed_row table caching (osquery#6508) Implement event batching support for Windows tables (osquery#6280) http: Use sync resolve (osquery#6490) Add support for basic chassis information (osquery#5282) Only emit 'denylist' warning once (osquery#6493) docs: Remove references to brew in macOS install (osquery#6494) Fix for osquery#5890: Event Format Results and the Kafka Logger (osquery#6449) make apt_sources table parsing much more resilient (osquery#6482) Make file and hash container columns hidden (osquery#6486) Update documentation to use 'allow list' and 'deny list' diction (osquery#6489) ...
This code makes the apt_sources table code much more defensive to unusual but still compliant sources.list files. It is based on the spec given here: http://manpages.ubuntu.com/manpages/xenial/man5/sources.list.5.html
all source line checking has been moved to
parseAptSourceLineso that it is easier to audit and commented.Expanded tests are included in this PR.
Of note: the column
nameis now made up of the uri (sans protocol) and the suite. Which makes more logical sense than joining the cache name with spaces.Addresses weaknesses in #6047 (comment)
@theopolis