Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carves: use full pathnames while creating an archive #7681

Merged
merged 6 commits into from
Aug 4, 2022
Merged

carves: use full pathnames while creating an archive #7681

merged 6 commits into from
Aug 4, 2022

Conversation

sharvilshah
Copy link
Member

Fixes #7679

Archives will now use full path names:

➜  scratch tar -tf helloworld.tar
/tmp/osquery_carve_f5613894-26e9-4c03-b171-411d5240e5b8/tmp/hello world.txt

➜  scratch tar -tf foo.tar
/tmp/osquery_carve_56c6dfe1-72f8-424e-99b5-8c6ff2395ed3/tmp/foo/foo 1/foo_random.data
/tmp/osquery_carve_56c6dfe1-72f8-424e-99b5-8c6ff2395ed3/tmp/foo/foo 2/foo_random.data
/tmp/osquery_carve_56c6dfe1-72f8-424e-99b5-8c6ff2395ed3/tmp/foo/foo 3/foo_random.data

@sharvilshah sharvilshah requested review from a team as code owners July 8, 2022 08:41
@sharvilshah sharvilshah marked this pull request as draft July 8, 2022 09:12
@sharvilshah sharvilshah closed this Aug 4, 2022
@sharvilshah sharvilshah reopened this Aug 4, 2022
@sharvilshah sharvilshah marked this pull request as ready for review August 4, 2022 11:13
@sharvilshah sharvilshah added ready for review Pull requests that are ready to be reviewed by a maintainer carving labels Aug 4, 2022
directionless
directionless approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. maybe worth some tests around the path handling on different platforms

@sharvilshah
Copy link
Member Author

Seems reasonable. maybe worth some tests around the path handling on different platforms

Tested locally on all three platforms! And the current carver test works great, that's how I knew it wasn't working correctly on windows.

@sharvilshah sharvilshah merged commit 644b950 into osquery:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
carving ready for review Pull requests that are ready to be reviewed by a maintainer
Projects
None yet
Milestone
No milestone
2 participants
@sharvilshah @directionless