Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune spec files by black/white lists #84

Merged
merged 3 commits into from
Aug 27, 2015
Merged

Prune spec files by black/white lists #84

merged 3 commits into from
Aug 27, 2015

Conversation

patrickcjh
Copy link
Contributor

To ensure GetCapabilitySpecs service returns the filtered specs.

@wjwwood
Copy link
Member

wjwwood commented Aug 17, 2015

@commaster90 Thanks for the pull request.

I'll have to think carefully about this one. Can you describe what the current behavior is and how that doesn't work for you and how this patch addresses that. Can you imagine a test which should fail before this patch and succeed afterwards?

@patrickcjh
Copy link
Contributor Author

The patch affects the result from this function: capabilities.service_discovery.spec_index_from_service.

Prior to this change, blacklisted capability interfaces were included in the returned result.
This function is used by rqt_capabilities, and therefore blacklisted interfaces were displayed in the capability graph.

We can blacklist some interface, and include a check in the file: test_service_discovery/test_spec_index_from_service.py.

To ensure GetCapabilitySpecs service returns the filtered specs.
@patrickcjh
Copy link
Contributor Author

Hope the test case can clarify the issue.

@wjwwood
Copy link
Member

wjwwood commented Aug 27, 2015

Thanks, that test was exactly what I was looking for. I understand what the issue was and how it solves the problem. This looks good to merge, thanks for your patience!

wjwwood added a commit that referenced this pull request Aug 27, 2015
Prune spec files by black/white lists
@wjwwood wjwwood merged commit 5dae913 into osrf:master Aug 27, 2015
@patrickcjh
Copy link
Contributor Author

Thanks.

@patrickcjh patrickcjh deleted the fix-1 branch August 28, 2015 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants