Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White list for capability server #34

Merged
merged 3 commits into from Nov 8, 2013
Merged

White list for capability server #34

merged 3 commits into from Nov 8, 2013

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 7, 2013

I'd like to be able to specify the packages, which the capability server checks for existing interfaces and providers.

The reason being that in the future there will probably be a significant amount of interfaces. If one does not specify (default) providers for each existing interface, then warnings are thrown on capability server startup.

The rocon_gateway uses both a black and white list and the app manager implements a white list by only loading apps, which are list in a file.

Example - app manager white list parameter (rapp_lists) set in the launch file:
https://github.com/robotics-in-concert/rocon_app_platform/blob/hydro-devel/rocon_app_manager/launch/standalone.launch

@bit-pirate
Copy link
Contributor Author

Follow up of #25.

Example:

<rosparam param="whitelist">
    - 'minimal_pkg/Minimal'
    - 'minimal_pkg/SpecificMinimal'
</rosparam>
@wjwwood
Copy link
Member

wjwwood commented Nov 7, 2013

Upgraded to a pull request

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b3c275a on issue_34 into 79a7a79 on master.

@bit-pirate
Copy link
Contributor Author

Is it possible to black/whitelist whole packages?

@wjwwood
Copy link
Member

wjwwood commented Nov 7, 2013

I will do that, I was wondering about that while implementing. With blacklisting packages do we need whitelisting of individual capabilities still?

@bit-pirate
Copy link
Contributor Author

Not important, but nice, I'd say. Imagining a package with lots of capabilities, some people might just want to use very few of them or might only have a subset of providers installed. Using black + white list would give them a way to get rid of the (default) providers at startup.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a677d05 on issue_34 into 79a7a79 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2741a78 on issue_34 into 79a7a79 on master.

wjwwood added a commit that referenced this pull request Nov 8, 2013
White list for capability server
@wjwwood wjwwood merged commit da4d263 into master Nov 8, 2013
@wjwwood wjwwood deleted the issue_34 branch November 8, 2013 06:23
@bit-pirate
Copy link
Contributor Author

Works great! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants