New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow provider specs to contain remapping rules #36
Conversation
Example from @bit-pirate: %YAML 1.1
---
name: kobuki_led
spec_version: 1
spec_type: provider
description: "Implements the LED capability for Kobuki's default LED, i.e. LED 1."
implements: kobuki_capabilities/LED
depends_on:
'kobuki_capabilities/KobukiBringup':
provider: 'kobuki_capabilities/kobuki_bringup'
remappings:
topics:
'led': '/mobile_base/commands/led1' |
@bit-pirate, so there is a remappings section already for each remapping in the Could this do what you want? |
For TB this would work, since most things will depend on the BringUp capability. However, I would prefer to make the remapping parameter generally available (not tied to |
I don't think so, I will add the option for a remappings section independent of the depends_on section. In that case do we need the optional remappings section for the depends_on section too? |
I'd say no. |
remappings are now specified at the provider level
Upgraded to a pull request. @bit-pirate for review |
Works like a charm. I have already implemented it in the app manager. Please merge it at your convenience. |
Allow provider specs to contain remapping rules
This was proposed as a solution to the providers which need to rename things in order to satisfy semantic interface names.
See: #22