When stopping a capability, stop all dependent capabilities as well

[esteve]

Doesn't look like this is happening right now.

[wjwwood]

This was working before, but it may have regressed.

Note that it will only stop them if they were not started by the user, i.e. if bar depends on foo and you start foo, and then bar, then stop bar, foo won't automatically stop.

[bit-pirate]

It works only, if one stops the same capability, which he has started before. Then all the cap's dependencies, which have been started automatically, are also stopped automatically. Stopping any other cap will only stop that cap's dependencies.

IMO all caps, which are running and dependent on each other should be stopped, e.g. it doesn't make sense to me to keep the FakeLaser (depthimage_to_laserscan) running, when the RGBDSensor (Kinect driver) has been stopped. Am I missing a valid example to keep dependent caps running?

[wjwwood]

So you're saying that if fake_laser depends on kinect and I start fake_laser, which in turn starts kinect, and I then stop kinect, fake_laser continues to run?

[bit-pirate]

So you're saying that if fake_laser depends on kinect and I start fake_laser, which in turn starts kinect, and I then stop kinect, fake_laser continues to run?

Correct.

[esteve]

I fixed this issue, but it seems Travis is having trouble installing empy, I'll have a look at it. Anyway, I ran the testsuite locally and all the tests passed.

[coveralls]

Coverage remained the same when pulling d31847b on esteve:stop-dependencies into 59d09f0 on osrf:master.

[bit-pirate]

Tested. Very nice! 👍

Please merge!

[wjwwood]

Agreed, +1