-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject sha256 labels for all target packages #90
inject sha256 labels for all target packages #90
Conversation
44562bb
to
5c01008
Compare
5c01008
to
de74c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
We should likely move some of these templates in a graveyard folder as some of them apply to images that will not be regenerated. (@ruffsl WDYT?)
Of the top of my head the changes to the following don't seem necessary (although don't hurt either):
- docker_templates/templates/docker_images/create_drcsim_image.Dockerfile.em
- docker_templates/templates/docker_images/create_gzserverX_image.Dockerfile.em
With or without the changes to the aforementioned files reverted, this PR looks good to me 👍
On the docker_images side, we'll likely need to update only a subset to not modify the Dockerfiles of the EOL images that are not rebuilt anymore. I'll comment directly on osrf/docker_images#454 for those comments
Moving the template files would require the update of the paths in the respective |
Thanks again @ipa-mdl for working on this ! |
Thanks @ipa-mdl ! Next we'll need to work on automating the upstream PRs with our @osrf-docker-builder bot. |
This PR addresses the SHA256 injection as proposed in osrf/docker_images#376
dict(name, version, sha256)
instead stringapt-get install -y --no-install-recommends
I can update the common snippet to take a list of
apt
arguments, if needed.