Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'putstr' attribute with 'printf' #3228

Closed
wants to merge 1 commit into from
Closed

replace 'putstr' attribute with 'printf' #3228

wants to merge 1 commit into from

Conversation

Maik93
Copy link

@Maik93 Maik93 commented Jun 12, 2022

This is due to braking changes on Agiodisc_t.

@traversaro
Copy link
Collaborator

Hi @Maik93 ! Gazebo Classic would need to continue to compile with older versions of graphviz, as those are the one available on many distribution on which Gazebo Classic is supported, so probably we may need to have some preprocessor logic to select which code to execute depending on the used graphviz version.

Furthermore, this specific change has been reverted (see https://gitlab.com/graphviz/graphviz/-/blob/a9c36efe4041cc16a54e834440e3a489eaa222e1/CHANGELOG.md#fixed) so probably the logic would need to have this piece of code just for graphviz 4.0.0, as the next release of graphviz will need again the old logic.

@acxz
Copy link
Contributor

acxz commented Jun 13, 2022

@traversaro thanks for commenting on this and providing more insight. In that case, it is prob best for us on archlinux to just use the previous graphviz with gazebo until 4.0.1 is released or manually patch the package on our end. It is prob not worth then to have a fix specifically for just an intermediate graphviz version in gazebo upstream.

@scpeters
Copy link
Member

ok, I'll close this for now, but feel free to reopen if you feel that a change is warranted

@scpeters scpeters closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants