Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch googletest to 1.10.0.2 #65

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Patch googletest to 1.10.0.2 #65

merged 1 commit into from
Jun 2, 2021

Conversation

homalozoa
Copy link
Contributor

Fix warning "may be used uninitialized" of googletest when compiling with GCC 11.1, change version to 1.10.0.2.

Change in this PR is same as google/googletest#3024.

See google/googletest#3219 for more details.

Signed-off-by: Homalozoa nx.tardis@gmail.com

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at past PRs, we don't tend to remove the tarball of the previous release. So please leave release-1.10.0.1.tar.gz in this PR.

Once that is fixed, I think we'll be good to run CI on this.

@homalozoa
Copy link
Contributor Author

homalozoa commented Jun 1, 2021

Hi, Chris @clalancette. The file I delete by mistake is already added back.

Fix warning "may be used uninitialized" of googletest when compiling with GCC 11.1, change version to 1.10.0.2

Signed-off-by: Homalozoa <nx.tardis@gmail.com>
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

All right, green CI all around. Merging this, thanks for the contribution!

@clalancette clalancette merged commit 65adefd into osrf:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants