This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
Implement Ingestors #164
Merged
Implement Ingestors #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the existing Dispensers into Dispensers and Ingestors. Ingestors will handle the taking in of objects delivered to them. Added a new set of messages for the Ingestors, which mimics the existing Dispenser messages. Modified the Delivery task to make use of the Ingestors. Added unit tests for the Ingestor and modified the existing Delivery test to use a flaky Ingestor instead of a flaky Dispenser.
aaronchongth
suggested changes
Aug 27, 2020
There was a problem hiding this comment.
Thanks for refactoring and adding the functionality for ingestors! Everything looks good to merge after the maintainer name change, and should be merged together with osrf/rmf_demos#117. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of a flaky Dispenser.
Initially considered refactoring the
IngestItemandDispenseItemstructs into a commonHandleItemtemplate struct, but it was not very extensible or modifiable, did not shorten the code by much, and also added a lot of complexity.