Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter_bridge echos back when it receives ROS messages #31

Closed
azeey opened this issue Aug 1, 2019 · 6 comments
Closed

parameter_bridge echos back when it receives ROS messages #31

azeey opened this issue Aug 1, 2019 · 6 comments

Comments

@azeey
Copy link
Contributor

azeey commented Aug 1, 2019

When publishing to the ROS side of the parameter_bridge node, it echos back the message. To test, with roscore running, in one terminal I ran

rosrun ros1_ign_bridge parameter_bridge test@std_msgs/String@ignition.msgs.StringMsg

In another (terminal 2),

rostopic echo /test

And finally

rostopic pub /test std_msgs/String "data: 'Hello'"

I expect to see one message in terminal 2, but I get:

data: "Hello"
---
data: "Hello"
---
@caguero
Copy link
Contributor

caguero commented Aug 1, 2019

And this isn't because rostopic pub keeps sending messages periodically, right? Alternatively, you could publish with the --once option to make sure.

@azeey
Copy link
Contributor Author

azeey commented Aug 1, 2019

I tried with --once and got the same result.

@chapulina
Copy link
Contributor

I can reproduce it. And ignition only gets the message once:

$ ign topic -e -t /test
data: "Hello"

@caguero
Copy link
Contributor

caguero commented Aug 1, 2019

Me too and as @chapulina mentioned it should only happen in the ROS->Ign direction. I think I know what's happening. I might need to touch Ignition Transport to avoid this issue here.

@caguero
Copy link
Contributor

caguero commented Aug 1, 2019

I have a potential fix in #33 .

@caguero
Copy link
Contributor

caguero commented Aug 2, 2019

Fixed in pull request #33 .

@caguero caguero closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants