Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF2 msgs not implemented in ros2 branch #116

Closed
09ubberboy90 opened this issue Oct 15, 2020 · 5 comments
Closed

TF2 msgs not implemented in ros2 branch #116

09ubberboy90 opened this issue Oct 15, 2020 · 5 comments
Labels
help wanted Extra attention is needed ROS 2 ROS 2

Comments

@09ubberboy90
Copy link
Contributor

PR #67 was merged in the melodic branch but has not been ported to the ROS2 branch.
This means there is no way to send tf messages to ignition for Ros2

Is there any plans to merge the melodic branch in the Ros2 branch sometime soon ?

If not I'm going to try and port in and will do a pull request
@osrf-triage osrf-triage added this to Inbox in Core development Oct 15, 2020
@chapulina chapulina added the ROS 2 ROS 2 label Oct 15, 2020
@chapulina
Copy link
Contributor

Is there any plans to merge the melodic branch in the Ros2 branch sometime soon ?

Unfortunately porting between ROS versions is not that straightforward and requires a separate pull request.

If not I'm going to try and port in and will do a pull request

That would be great, thanks!

@chapulina chapulina removed this from Inbox in Core development Oct 15, 2020
@chapulina chapulina added the help wanted Extra attention is needed label Oct 15, 2020
@09ubberboy90
Copy link
Contributor Author

09ubberboy90 commented Oct 15, 2020 •
edited

That would be great, thanks!

Cool I'm gonna try and port that feature. Not sure about doing a full merge as I've never done that.

@chapulina
Copy link
Contributor

Not sure about doing a full merge as I've never done that.

Yeah the merge wouldn't be a good idea. You can try cherry-picking 7b06c21 to a ROS 2 branch (I suggest dashing if possible, otherwise ros2), then manually fixing the differences.

chapulina pushed a commit that referenced this issue Oct 22, 2020
@09ubberboy90 @iche033
Add TFMessage / Pose_V and Float64 / Double conversions (#117)
ce8b524 
Addresses issue #116 

Signed-off-by: 09ubberboy90 <2330834a@student.gla.ac.uk>
Co-authored-by: iche033 <ichen@osrfoundation.org>
@09ubberboy90
Copy link
Contributor Author

I can close this right?

@chapulina
Copy link
Contributor

Done in #117, thanks @09ubberboy90 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chapulina @09ubberboy90