Changelog: Explicitly cite "Custom elements and attributes" proposal #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Er, this (b11ef71) is wrong. Will update links to point to actual PR this time: |
EricCousineau-TRI
force-pushed
the
feature-2020-05-09-changelog-custom-elements
branch
2 times, most recently
from
987daec
to
82cc0b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 59 59
Lines 9066 9066
=======================================
Hits 7858 7858
Misses 1208 1208 Continue to review full report at Codecov.
|
scpeters
approved these changes
May 12, 2020
scpeters
added this to In progress
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
via automation
scpeters
moved this from In progress
to In Review
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
scpeters
force-pushed
the
feature-2020-05-09-changelog-custom-elements
branch
from
82cc0b7
to
0844fe4
Compare
SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
automation
moved this from In Review
to Done
May 16, 2020
scpeters
pushed a commit
that referenced
this pull request
Jun 2, 2020
…275) Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
nkoenig
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hard to trace the implementation of this proposal; from ros/urdfdom_headers#59 (comment), I ended up finding it in this commit and PR: