-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move list of debian dependencies to packages.apt #392
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf9 #392 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 59 59
Lines 9181 9181
=======================================
Hits 7919 7919
Misses 1262 1262 Continue to review full report at Codecov.
|
apparently including the string
|
Yeah I noticed it here 🙃 That's why I did I need to think of a better workaround, because the actions CI relies on finding dependencies of several packages in a workspace, on different folders. |
If a git branch name contains packages.apt, it can break our jenkins script (see gazebosim/sdformat#392). Signed-off-by: Steve Peters <scpeters@openrobotics.org>
fix for release-tools: gazebo-tooling/release-tools#323 |
If a git branch name contains packages.apt, it can break our jenkins script (see gazebosim/sdformat#392). Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@osrf-jenkins run tests please |
1 similar comment
@osrf-jenkins run tests please |
CI is clear 🙌 Can we get this in? |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…es.apt Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ges.apt Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ges.apt Signed-off-by: Louise Poubel <louise@openrobotics.org>
…es.apt Signed-off-by: Louise Poubel <louise@openrobotics.org>
This will help keeping the list of dependencies in a single place, which is easier to maintain. Being close to the source code also makes it simple to update when a PR introduces a new dependency.
Our Jenkins CI can start referring to this list instead of dependencies_archive.sh (see gazebo-tooling/release-tools#317) and other tools, like the API doc uploader can also make use of it.
The pattern we've been using is:
packages.apt
for dependencies common to all platformspackages-<distro>.apt
for dependencies specific to Ubuntu