Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap description tags in CDATA #483

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Wrap description tags in CDATA #483

merged 2 commits into from
Feb 4, 2021

Conversation

claireyywang
Copy link
Contributor

@claireyywang claireyywang commented Feb 3, 2021

closes #375

This PR wraps all <description> content in <![CDATA[]]>, which was stripped away when full sdf files were generated. All symbols should show up properly on website upon merging.

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 3, 2021
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
@claireyywang claireyywang mentioned this pull request Feb 3, 2021
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I'll merge and upload the new full_*.sdf files.

@azeey azeey merged commit b72da73 into sdf9 Feb 4, 2021
@azeey azeey deleted the claire/wrap-chars branch February 4, 2021 17:25
@EricCousineau-TRI
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants