Tune controller for moving to artifact origin #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that the robot could spin in place in the starting area and not move to the entrance. This is mainly caused by slow pose responses from rosservice calls to the
pose_from_artifact_originservice, which occurs when the system is under heavy load. Because the cmd vel persists on the simulation end, the slow pose updates cause the robot rotation to overshoot . When that happens, the current behavior is to to just keep turning in the same direction until it's within the the desired yaw angle threshold.The main change in this PR is that the vel commands are now proportional. If the robot overshoots when turning, it'll correct itself by rotating the other direction.
Also fixed Dockerfile