Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean: Following up to updated content with changing README #22

Merged
merged 11 commits into from Dec 26, 2016
Merged

Korean: Following up to updated content with changing README #22

merged 11 commits into from Dec 26, 2016

Conversation

ianychoi
Copy link
Contributor

Hello!

I would like to follow up to updated content in Japanese into Korean documentation.

The next possible work would be to follow 3f501ad and others, but I have found that the amount of work is relatively big. So I think I need to separate into two pull requests. This is the first.

Although I have read up-to-dated README to best build on Ubuntu 16.04 so late, I have been so surprised since it was so nice and cool! Also travis looks cool. I would also like to incorporate travis into my forked repository later.

Please review my commits, thanks a lot!

With many thanks,

/Ian

@ianychoi
ko: link_aggregation: Specify the port number of the controller
70c515d 
(from commit 4933260)
@ianychoi
ko: link_aggregation: Fix a import Link error problem
1e1e3a3 
(from commit 1810911)
@ianychoi
ko: spanning_tree: Specify the port number of the controller
b71f600 
(from commit 0e956e5)
@ianychoi
ko: spanning_tree: Fix a import Link error problem
a6a3d0d 
(from commit 18892f2)
@ianychoi
ko: switching_hub: Add version updated and Installation procedure
cef7a8c 
(from commit b30e942)
@ianychoi
ko: contribute: Update the description of support version of Python
510183b 
(from commit a7585cf)
@ianychoi
ko: sw_test_tool: Support OpenFlow 1.0
8fce562 
(from commit feaa2c9)
@ianychoi
ko: packet_lib: Modify the link destination URL of API Reference
4480b56 
(from commit b45628c)
@ianychoi
ko: ofproto_lib: Fix the module name of Ryu
4840e8a 
(from commit a890d2f)
@ianychoi
ko: switching_hub: Reduce the version values of OpenFlow parser
c62b5d7 
(from commit ed0dbab)
@ianychoi
ko: README: fix typos with up-to-date build method
a630a3b 
Since project README best describes build procedures
for all documents including Korean, it is much better
to indicate it with appropriate notes.
Also, this commit fixes several typos and changes formattings.
@iwaseyusuke
Copy link
Contributor

Hi @ianychoi
I'm very sorry for the delay.

Your PR is very nice!
I would like to merge your PR.

BTW, ko source could be built on Travis-CI?

@ianychoi
Copy link
Contributor Author

ianychoi commented Dec 5, 2016

Hello @iwaseyusuke ,

That's fine :)
From my search on this repository, ko sources are already built on Travis-CI.
For example, 3db5612 shows that Korean files are successfully generated.

@iwaseyusuke
Copy link
Contributor

Hi @ianychoi
I'm very sorry for the delay again.

We faced another problem that Ryu-Book can not be built with the latest Sphinx 1.5+.
I made a temporary patch for this problem.

Then, I want to merge your branch and wait and see it.
Thanks.

@iwaseyusuke iwaseyusuke merged commit 352fc7e into osrg:master Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ianychoi @iwaseyusuke