feat(rules): Add CVSS 3.1/4 to high vulnerability in dependency rule #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for a sequential commit where CVSS:3.1 and CVS:4.0 comparator functions will be added. Signed-off-by: Thomas Steenbergen <opensource@steenbe.nl>
Prior to this change a package with a high severity vulnerability encoded in CVSS 3.1 or 4.0 would not trigger a policy rule violation. Signed-off-by: Thomas Steenbergen <opensource@steenbe.nl>
tsteenbe
force-pushed
the
fix-policy-rule-high-severity-vuln-in-dep
branch
from
f5de453
to
869b512
Compare
sschuberth
reviewed
Jun 4, 2024
| @@ -1546,10 +1546,16 @@ fun RuleSet.vulnerabilityWithHighSeverityInDependencyRule() = packageRule("HIGH_ | |||
| -isProject() | |||
| -isExcluded() | |||
| +AnyOf( | |||
| hasVulnerability(maxAcceptedSeverity, "CVSS2") { value, threshold -> | |||
| hasVulnerability(maxAcceptedSeverity, "CVSS:2") { value, threshold -> | |||
There was a problem hiding this comment.
Note that this would now disregard vulnerabilities that literally use "CVSS2" as the scoring system as we compare scoring systems by their strict string representation currently:
Similar below. So this change likely has unwanted side effects.
There was a problem hiding this comment.
I'll take a brief look at changing the hasVulnerability rule itself to address that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change a package with a high severity vulnerability encoded in CVSS 3.1 or 4.0 would not trigger a policy rule violation.