-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curations): Add a VCS curation for XMLUnit < 2.0 #194
Conversation
@@ -0,0 +1,7 @@ | |||
- id: "Maven:xmlunit:xmlunit:(,2.0[" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message: How about the following title?
feat(curations): Set the VCS info for xmlunit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to emphasize it's for versions < 2 only, as 2.x versions do not have these issues anymore.
The POM, e.g. https://repo1.maven.org/maven2/xmlunit/xmlunit/1.3/xmlunit-1.3.pom, contains a `BSD-3-Clause` | ||
license header but a non-SPDX license name tag. Also the SVN repository URL is wrong as it either points to the | ||
view URL or hard-codes the trunk revision. | ||
declared_license_mapping: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
feat(curations): Map a declared license for xmlunit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically have no objections, but I'd just like to understand: How is that message better than mine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the bottom commit "curation(s)" is not mentioned twice...less redundant.
The proposed way is a bit shorter and focus a tad more on describing the effect on the curation, not so much the property used for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for explaining. I made the messages a bit more compact.
Note that XMLUnit 2.x is hosted at [1]. [1]: https://github.com/xmlunit/xmlunit Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
da4165d
to
32908ab
Compare
Note that XMLUnit 2.x is hosted at 1.