feat(curations): Add a VCS curation for XMLUnit < 2.0 #194
Conversation
| @@ -0,0 +1,7 @@ | |||
| - id: "Maven:xmlunit:xmlunit:(,2.0[" | |||
There was a problem hiding this comment.
commit message: How about the following title?
feat(curations): Set the VCS info for xmlunit
There was a problem hiding this comment.
I'd like to emphasize it's for versions < 2 only, as 2.x versions do not have these issues anymore.
| The POM, e.g. https://repo1.maven.org/maven2/xmlunit/xmlunit/1.3/xmlunit-1.3.pom, contains a `BSD-3-Clause` | ||
| license header but a non-SPDX license name tag. Also the SVN repository URL is wrong as it either points to the | ||
| view URL or hard-codes the trunk revision. | ||
| declared_license_mapping: |
There was a problem hiding this comment.
Same here:
feat(curations): Map a declared license for xmlunit
There was a problem hiding this comment.
I basically have no objections, but I'd just like to understand: How is that message better than mine?
There was a problem hiding this comment.
For the bottom commit "curation(s)" is not mentioned twice...less redundant.
The proposed way is a bit shorter and focus a tad more on describing the effect on the curation, not so much the property used for it.
There was a problem hiding this comment.
I see, thanks for explaining. I made the messages a bit more compact.
Note that XMLUnit 2.x is hosted at [1]. [1]: https://github.com/xmlunit/xmlunit Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
xmlunit-curation
branch
from
da4165d
to
32908ab
Compare
Note that XMLUnit 2.x is hosted at 1.