Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sw360Storage: Omit return types for function expressions #3478

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

sschuberth
Copy link
Member

Omit return types in a few simple cases, partly to be able to improve
formatting.

Signed-off-by: Sebastian Schuberth sebastian.schuberth@bosch.io

Omit return types in a few simple cases, partly to be able to improve
formatting.

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
Copy link
Member

@oheger-bosch oheger-bosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I prefer having explicit return types as they reduce the cognitive load somewhat. But if omitting them is common convention, I do not object.

@sschuberth
Copy link
Member Author

Personally, I prefer having explicit return types as they reduce the cognitive load somewhat. But if omitting them is common convention, I do not object.

To be fair, I wouldn't says it's "common convention"; in fact, I believe there even are IDE hints sometimes that suggest to add explicit return types in public APIs to make API breakages more obvious. It's just my personal preference to omit explicit return types in simple cases (i.e. where the "cognitive load" is low) for a simpler visual appearance.

Does that change your mind now @oheger-bosch, and would you prefer to withdraw your approval / me to drop this PR?

@oheger-bosch
Copy link
Member

Does that change your mind now @oheger-bosch, and would you prefer to withdraw your approval / me to drop this PR?

I am pretty much indifferent. Just go ahead as you like.

@sschuberth sschuberth merged commit cf6acb7 into master Jan 5, 2021
@sschuberth sschuberth deleted the minor-formatting-changes branch January 5, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants