Minor refactorings in StatisticsCalculator
#8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the local helper function `countLicenses` operate on `Set<Identifier>` instead of `Collection<Identifier>` as it is only ever called on sets. This makes the `distinct` call redundant. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
`eachCount()` already returns a map. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8603 +/- ##
=========================================
Coverage 67.70% 67.70%
Complexity 1007 1007
=========================================
Files 246 246
Lines 7924 7924
Branches 883 883
=========================================
Hits 5365 5365
Misses 2176 2176
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.