Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactorings in StatisticsCalculator #8603

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Minor refactorings in StatisticsCalculator #8603

merged 2 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. refactor(reporter): Make a local function more specific 

    Let the local helper function `countLicenses` operate on
`Set<Identifier>` instead of `Collection<Identifier>` as it is only ever
called on sets. This makes the `distinct` call redundant.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
    @mnonnenmacher
    mnonnenmacher committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    31cfc58 View commit details
    Browse the repository at this point in the history

  2. chore(reporter): Remove a redundant toMap() call 

    `eachCount()` already returns a map.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
    @mnonnenmacher
    mnonnenmacher committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bc8c264 View commit details
    Browse the repository at this point in the history