[WIP] Integration with Jenkins to display test results #238
Conversation
…st added handlebar helper that will be used to compare and display the results
…extra work for scenario outline, added a few temp css for it as well
…o outline and those with subset names
… file, needs changing so its created automatically)
…e individual jobs
[wip] Feature/jenkins results
|
@BenSummerfieldCowe Hi Ben, looks good. Would you mind addressing the new Code Climate issues? It would also be nice if you could replace all the HTML strings with Handlebars templates, it's possible to pass an array, e.g. a list of Jenkins jobs, to a template (or partial) and have it iterate over the list for you. Shout if you need a hand or have any questions, I'm happy to help. Other than that I am happy if @sponte is 😃 . |
|
@jimCresswell Hey Jim, thanks for the advice, will take at implementing suggestions and resolving Code Climate issues. I just had a chat with Stan as well and he gave some suggestions to make it less tied to jenkins. Will close this request and work on changes. Thanks |
|
@BenSummerfieldCowe yep, Stan is good at architecture. If you want to make the changes in the same pull request that is fine, plus it gives us a record of the discussion and changes, absolutely up to you though! |
| * @return a promise for the repo metadata. | ||
| */ | ||
| function getResults(projectData) { | ||
| for(var j=0;j<projectData.config.jenkinsJobs.length;j++) { |
There was a problem hiding this comment.
Hey Ben,
Variables created with var are function scoped, the declaration (but not the assignment) will be hoisted to the top of the current function scope. So generally it's considered good form to not declare the variable in the loop but to put it at the top of the containing function. On the other hand, if you want block scoped variables that only exist within the loop you can declare them with the let keyword (assuming the application is running on a recent version of Node http://node.green/#let ).
|
Good progress, I made a couple of minor comments. |
…ments Feature/fixing review comments
Removing unused variable
| * Hits a url, calls a call back function and returns an array | ||
| */ | ||
| function httpGet(theUrl, callBack, async) { | ||
| var xmlHttp = new XMLHttpRequest(); |
There was a problem hiding this comment.
I would recommend using https://www.npmjs.com/package/request-promise instead of XMLHttpRequest, it will make it easier to query external sources
Removing un used method
Attempt to fix issue with server not closing
Updating the port to see if getting stuck
… goto the other page
Made some changes for displaying results from jenkins (currently limited to jenkins only and only one level folder)