Fix writing of checksum for blocks around the segment boundary. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In direct write mode, pg_bulkload loads data into a fixed number of private buffers and once they are full, writes those buffers to the actual relation file. Each page's checksum is set before writing to the file, during which it must pass the block number for checksum calculation. Due to a bug in how block number is calculated, it calculated the wrong checksum in certain cases, especially, when a segment of the relation is about to get full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In direct write mode, pg_bulkload loads data into a fixed number of
private buffers and once they are full, writes those buffers to the
actual relation file. Each page's checksum is set before writing to
the file, during which it must pass the block number for checksum
calculation. Due to a bug in how block number is calculated, it
calculated the wrong checksum in certain cases, especially, when a
segment of the relation is about to get full.
Fixes #24.