Fix crash due to improper memory context handling in some cases #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncSource mechanism which uses a separate thread to read data can sometimes try to manipulate an address that may be invalid because of memory context reset or delete by the main thread. Fix that by implementing a dedicated memory context for AsyncSource, which is only manipulated in the reading thread. Fixes #27.
|
The commit message says: Anyway, separation of memory context helps solve the problem, but I am open to any criticism of that. |
Commit 5a1bc58 introduced a new context for AsyncSource's needs, but failed to allocate the memory for buffer during initializion in that context. Fix that. Also, add some comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncSource mechanism which uses a separate thread to read data can
sometimes try to manipulate an address that may be invalid because of
memory context reset or delete by the main thread.
Fix that by implementing a dedicated memory context for AsyncSource,
which is only manipulated in the reading thread.
Fixes #27.