Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows an optionnal Reply-To mail header #727

Merged
merged 2 commits into from
Mar 9, 2016
Merged

Allows an optionnal Reply-To mail header #727

merged 2 commits into from
Mar 9, 2016

Conversation

calve
Copy link
Contributor

@calve calve commented Jan 4, 2016

Hi all. I started writing a patch to allow adding a Reply-To header to the mails sent by Ossec.

This patch still needs testing on my side (and documentation writing), but I would like to have an early code-review in case I missed something; so here it is.

Review on Reviewable

@calve
Copy link
Contributor Author

calve commented Jan 6, 2016

So this is working as expected on my side; the alerts I receive actually contains the Reply-to header. However I have no clue why the build did not pass, but it seems to fail before my changes.

Also I've committed the patch for the documentation at ossec/ossec-docs#149

@ddpbsd
Copy link
Member

ddpbsd commented Jan 7, 2016

The build failures are unrelated to your submission. I've spent some time troubleshooting it, but haven't figured it out just yet (and haven't had time to contact travis-ci about it).
Thanks for submitting the doc PR, I really appreciate it. At a glance this looks good, but I want to look it over again when I have more than a minute or two *unless someone else gets to it first!).

@dcid
Copy link

dcid commented Feb 25, 2016

Really curious here. Why you need a reply-to there? :)

Just trying to think of use cases.

@calve
Copy link
Contributor Author

calve commented Feb 25, 2016

My use case is the following; Ossec sends mails from ossecm@domain (which is the default) to alerts@domain, which is actually an internal mailing-list in the company.

When I reply to a mail alert and I am not fully awake, I sometime just forgot to change the recipient to alerts@domain instead of ossecm@domain, and the mail is bounced back, which is not what I want. Having a Reply-To: alerts@domain header will simplify this and reduce the number of undelivered mails and missed conversations.

Last, I wanted to dig a bit in the OSSEC code ( :

May I ask you a time window for the merge of this feature ?

@jrossi
Copy link
Member

jrossi commented Mar 5, 2016

@calve Was going to merge, but looks like this has some conflicts now. Could you sync this branch up with master? Will merge afterwards.

@calve
Copy link
Contributor Author

calve commented Mar 5, 2016

Thanks. I rebased my branch.

dcid pushed a commit that referenced this pull request Mar 9, 2016
Allows an optionnal ``Reply-To`` mail header
@dcid dcid merged commit 12b9ca7 into ossec:master Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants