Fixed some bugs referred to GeoIP #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix two issues:
When parsing rules with option
<if_matched_sid>the searching function is assigned toSearch_LastSids()and then it's overwritten withSearch_LastEvents()(for rules with<check_diff>). This was done at commit 3a36fec, in fact the code to compare the geolocation string appears onSearch_LastSids()and not atSearch_LastEvents().On the other hand, geolocation info is always reloaded when printing the alert, this may cause a memory leak. I propose to check that the geolocation string hasn't been yet created.