Start Rubocop for existing codebase #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 96.7% 96.71% +<.01%
==========================================
Files 38 38
Lines 1731 1734 +3
==========================================
+ Hits 1674 1677 +3
Misses 57 57
Continue to review full report at Codecov.
|
.rubocop_todo.yml
Outdated
| # Cop supports --auto-correct. | ||
| Layout/CommentIndentation: | ||
| Exclude: | ||
| - 'lib/ossert/repositories.rb' |
There was a problem hiding this comment.
Hmm. Why do I see there much more Exclude: then before?
Also, most of them support auto-correct option.
Maybe, it's worth to run rubocop -a and commit (and review) those changes.
|
Hi @sclinede I have done |
.rubocop_todo.yml
Outdated
|
|
||
| # Offense count: 27 | ||
| Metrics/AbcSize: | ||
| Max: 150 |
There was a problem hiding this comment.
Was 16 but became 150... Maybe we could Exclude something here and restore previous restriction?
.rubocop_todo.yml
Outdated
|
|
||
| Style/Documentation: | ||
| Enabled: false | ||
| Max: 240 |
There was a problem hiding this comment.
Hmm. I don't like such large lines. Maybe we could Exclude some files and enforce previous value.
.rubocop_todo.yml
Outdated
| Exclude: | ||
| - 'lib/ossert/fetch/github.rb' | ||
| - 'lib/ossert/fetch/stackoverflow.rb' |
There was a problem hiding this comment.
Only 2 cases. Maybe we're able to fix them, too
.rubocop_todo.yml
Outdated
| # Offense count: 1 | ||
| Naming/MemoizedInstanceVariableName: | ||
| Exclude: | ||
| - 'lib/ossert/fetch/rubygems.rb' |
There was a problem hiding this comment.
Only 1 case. Maybe it worth to push it)
.rubocop_todo.yml
Outdated
| Exclude: | ||
| - 'lib/ossert/fetch/github.rb' | ||
| - 'config/sidekiq.rb' |
|
Finally I came back to previous limit values (that was, but did not worked 😄 ), added some excludes and fixed some minor offences |
|
Perfect 👍 |
|
Cool. Thank you for patience 😄 |
No description provided.