Update GitHub client version. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we were in lock-step with Scorecards in order to share clients. Now, go-github has added a method to get the internal http client, therefore we can create new GitHub clients on the fly to convert major versions. See binary.go for conversion.
inferno-chromium
approved these changes
Sep 16, 2021
| @@ -8,11 +8,11 @@ require ( | |||
| github.com/google/go-cmp v0.5.6 // indirect | |||
| github.com/google/go-github/v29 v29.0.3 // indirect | |||
| github.com/google/go-github/v32 v32.1.0 | |||
There was a problem hiding this comment.
i think we need to clean these older version sometime.
There was a problem hiding this comment.
29 is used indirectly somewhere as a sub-dep. 32 is used by scorecards. I'll make an issue there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were in lock-step with Scorecards in order to share clients. Now,
go-github has added a method to get the internal http client, therefore we can
create new GitHub clients on the fly to convert major versions. See binary.go
for conversion.