Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven and Gradle not in the Top 2000 java list #25

Closed
bmarwell opened this issue Dec 12, 2020 · 6 comments
Closed

Maven and Gradle not in the Top 2000 java list #25

bmarwell opened this issue Dec 12, 2020 · 6 comments

Comments

@bmarwell
Copy link

bmarwell commented Dec 12, 2020

Hi,

I just saw that the Maven and Gradle projects are less important that 2000 java projects where they are used in as a build tool.
Maybe due to the fact that they:

Probably the same for other languages and build-tools, but haven’t checked.

@melix
Copy link

melix commented Dec 12, 2020

For Gradle, I ran the CLI tool and it gives:

name: gradle
url: https://github.com/gradle/gradle
language: Groovy
created_since: 137
updated_since: 0
contributor_count: 583
org_count: 5
commit_frequency: 184.3
recent_releases_count: 41
closed_issues_count: 1366
updated_issues_count: 2216
comment_frequency: 1.9
dependents_count: 40828
criticality_score: 0.86789

I think it's not listed because it says "Language Groovy", where most of the production code is Java: we have more tests than production code, and tests are indeed written in Groovy.

But I agree that the presence of any .gradle(.kts) file should could as a dependency.

@inferno-chromium
Copy link
Contributor

inferno-chromium commented Dec 12, 2020

Need to add Groovy language in Java language list, that should fix Gradle.

Maven, i will investigate more, this should show up, need to regenerate list.
maven,https://github.com/apache/maven,Java,141,0,177,11,3.4,5,31,49,2.0,43132,0.72458

@melix
Copy link

melix commented Dec 13, 2020

Adding Groovy will help but it doesn't change the fact that if any protect uses Gradle or Maven to build, then it should minimally count as a dependency to them.

@inferno-chromium
Copy link
Contributor

Adding Groovy will help but it doesn't change the fact that if any protect uses Gradle or Maven to build, then it should minimally count as a dependency to them.

Yes we are thinking of dependencies, see Issue 31 and Issue 8 [not adding hash to avoid cross linking].

@inferno-chromium
Copy link
Contributor

Graddy and other Groovy languages are added in http://commondatastorage.googleapis.com/ossf-criticality-score/java_top_200.csv

Maven will be added once #33 is fixed, tracking it there.

@inferno-chromium
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants