Error Condition will Never Occur

[nathannaveen]

I was just testing marshalToMap() in internal/signalio/helpers.go and realized that the error statement will never be used.

criticality_score/internal/signalio/helpers.go

Lines 39 to 40 in 27ad7d2

	if s, err := marshalValue(v); err != nil {
	return nil, fmt.Errorf("failed to write field %s: %w", k, err)

The error statements are never used because marshalValue() in internal/signalio/csv.go only returns an error when the value passed to it is a map, slice, or struct (The case defaults for any type that is not an int, bool, int16, time.Time, nil and so on). But since it is called with the key value of signal.SetAsMap(s, true) where s is a signal.Set. Set is:

criticality_score/internal/collector/signal/signal.go

Lines 82 to 85 in 27ad7d2

	func (s *Field[T]) Set(v T) {
	s.value = v
	s.set = true
	}

Set takes a parameter v which is of type SupportedType. Since SupportedType does not include maps, slices, and structs, marshalValue will never return an error.

[nathannaveen]

This is invalid because of the example given by @calebbrown: #301 (comment)