Unit tests for Weighted Arithmetic Mean and Distribution #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathannaveen
changed the title
calebbrown
requested changes
Nov 23, 2022
nathannaveen
force-pushed
the
nathan/feat/wamtest
branch
from
e394bfc
to
473ce87
Compare
calebbrown
requested changes
Nov 24, 2022
calebbrown
requested changes
Nov 25, 2022
calebbrown
requested changes
Nov 27, 2022
- Added unit tests for WAM. Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
- Added unit tests for distribution Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
- formatted WAM - formatted wam_test - Edited test for wam_test Addressed Code Review Comments - Included additional tests - Refactored structs within tests - Re-formatted code Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nathannaveen
force-pushed
the
nathan/feat/wamtest
branch
from
c3ecae3
to
534e3e2
Compare
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
requested changes
Nov 30, 2022
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
approved these changes
Dec 1, 2022
Yay! Thanks for all your reviews! Merged! 🥳 |
nathannaveen
added a commit
to nathannaveen/criticality_score
that referenced
this pull request
Feb 9, 2023
* Unit tests for Weighted Arthmetic Mean - Added unit tests for WAM. Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Unit tests for distribution - Added unit tests for distribution Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed WAM issues - formatted WAM - formatted wam_test - Edited test for wam_test Addressed Code Review Comments - Included additional tests - Refactored structs within tests - Re-formatted code Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Refactored Code Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Updated based on code review comments Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Removed the ignored files Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed the validation after unmarshalling Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed code review comment Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed based on comment Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Co-authored-by: Caleb Brown <calebbrown@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com