Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests - scorer/input #255

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Conversation

nathannaveen
Copy link
Contributor

  • Added unit tests for scorer/input

Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com

- Added unit tests for scorer/input

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Copy link
Contributor Author

@calebbrown 👀

@calebbrown calebbrown self-requested a review November 28, 2022 00:17
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Copy link
Contributor Author

@calebbrown, a friendly ping!

Copy link
Contributor

@calebbrown calebbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just one minor change!

internal/scorer/algorithm/input_test.go Outdated Show resolved Hide resolved
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@calebbrown calebbrown merged commit 8a23fdf into ossf:main Jan 10, 2023
nathannaveen added a commit to nathannaveen/criticality_score that referenced this pull request Feb 9, 2023
* Unit tests - scorer/input

- Added unit tests for scorer/input

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Changed formating

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

* Updated Based on Code Review Comments

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Co-authored-by: Caleb Brown <calebbrown@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants