Unit tests - internal/scorer/value #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests for internal/scorer/value Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
requested changes
Dec 6, 2022
| "testing" | ||
| ) | ||
|
|
||
| func TestExistsCondition(t *testing.T) { |
There was a problem hiding this comment.
I think TestExistsCondition and TestNotCondition can be combined into a single test e.g. TestCondition.
Rather than "f", have "condition" and specify the condition in each test struct.
There was a problem hiding this comment.
I have combined TestExistsCondition and TestNotCondition into one test called TestCondition. But I don't understand what you mean by
"Rather than
"f", have"condition"and specify the condition in eachteststruct."
Could you please clarify?
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
|
@calebbrown, a friendly ping! |
calebbrown
approved these changes
Dec 22, 2022
nathannaveen
added a commit
to nathannaveen/criticality_score
that referenced
this pull request
Feb 9, 2023
* Unit tests - internal/scorer/value - Added unit tests for internal/scorer/value Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Updated based on code review comments Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Renamed function Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Co-authored-by: Caleb Brown <calebbrown@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com