Included tests for internal/log/env #309
Conversation
- Included tests for internal/log/env - Included licenses for `env.go` and `config.go` Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
internal/log/env_test.go
Outdated
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got, _ := tt.e.MarshalText() // this function never returns an error |
There was a problem hiding this comment.
There should be a check that err is always nil so the assertion is checked.
There was a problem hiding this comment.
Thanks, I forgot about that when writing the test! I have added the error check err != nil.
internal/log/env_test.go
Outdated
| t.Run(tt.name, func(t *testing.T) { | ||
| got, _ := tt.e.MarshalText() // this function never returns an error | ||
|
|
||
| if !reflect.DeepEqual(got, tt.want) { |
There was a problem hiding this comment.
bytes.Equal() a better choice than DeepEqual
There was a problem hiding this comment.
I have changed it from reflect.DeepEqual() to bytes.Equal().
internal/log/env_test.go
Outdated
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Setenv(string(tt.text), tt.value) |
There was a problem hiding this comment.
I don't think this call does anything and probably should be removed, along with tt.value
There was a problem hiding this comment.
I have removed the t.Setenv() but I kept the tt.value because I added a check test.e.String() != test.value.
internal/log/env_test.go
Outdated
| value: "dev", | ||
| }, | ||
| } | ||
| for _, tt := range tests { |
There was a problem hiding this comment.
nit: test is a better than tt as tt is very similar to t
There was a problem hiding this comment.
I have changed all the tt's to test.
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
* Included tests for internal/log/env - Included tests for internal/log/env - Included licenses for `env.go` and `config.go` Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> * Fixed based on code review Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> Co-authored-by: Caleb Brown <calebbrown@google.com>
env.goandconfig.goSigned-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com