Refactored internal/scorer/scorer #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `internal/scorer/scorer.go` to improve readablilty. Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
requested changes
Feb 9, 2023
nathannaveen
force-pushed
the
nathan/feat/refactorScorer
branch
from
9e1b7c2
to
30799c7
Compare
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nathannaveen
force-pushed
the
nathan/feat/refactorScorer
branch
3 times, most recently
from
e728852
to
9f9c79d
Compare
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
…feat/refactorScorer
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nathannaveen
force-pushed
the
nathan/feat/refactorScorer
branch
from
bce126b
to
0e819c4
Compare
Closed
|
I have included tests for |
calebbrown
requested changes
Feb 16, 2023
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
|
@calebbrown A friendly ping! |
calebbrown
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/scorer/scorer.goto improve readablilty.Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com