Refactored internal/collector/depsdev/source #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `DefaultDatasetName` wasn't used, so I removed it. - I also replaced all of the `return err` with `return fmt.Errorf()` because it's considered good practice in Go to use fmt.Errorf() instead of just returning "err" as it provides more informative error messages. The fmt.Errorf() function formats a string into an error, allowing for added context and information that can aid in debugging and troubleshooting. On the other hand, returning just "err" without any extra information can make it harder to comprehend the error's cause and solution. Furthermore, using a formatted error message enhances error handling and debugging consistency. Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultDatasetNamewasn't used, so I removed it.return errwithreturn fmt.Errorf()because it's considered good practice in Go to usefmt.Errorf()instead of just returningerras it provides more informative error messages. Thefmt.Errorf()function formats a string into an error, allowing for added context and information that can aid in debugging and troubleshooting. On the other hand, returning justerrwithout any extra information can make it harder to comprehend the error's cause and solution. Furthermore, using a formatted error message enhances error handling and debugging consistency.Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com