Add logging to generate script #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inferno-chromium
requested changes
Jan 8, 2021
criticality_score/generate.py
Outdated
| print( | ||
| f'Exception occurred when reading repo: {repo_url}\n{exp}') | ||
| msg = f'Exception occurred when reading repo: {repo_url}\n{exp}' | ||
| print(msg) |
There was a problem hiding this comment.
This is not the right use of logging methods, to just log errors and not anything else. I think you can add logging handler, but then convert all the prints to use that logging pipelines (regular print should be info level). Then log file will have all log data, info and errors. and you can search for errors using error log level.
There was a problem hiding this comment.
I see, since logger also prints the messages to the console.
Updates in last commit:
- Move logger to global
- Replace print with logger.info
- Set loglevel to info
I also tried to share the logger with run script. The only way that I could do it was to pass it as an argument in each function. e.g. def get_repository(url, logger):
I assume that there's a better way to do it, so I'm skipping that one for now.
- Replace print with logger.info - Set loglevel to info
inferno-chromium
approved these changes
Jan 9, 2021
inferno-chromium
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run generate script for large number of repos, it becomes difficult to follow the exceptions.
Not sure what are the best practices but I added basic logging by following this example. Looks like it's doing the job:
https://stackoverflow.com/questions/15474095/writing-a-log-file-from-python-program
As usual, feel free to accept/discard it