Add page query retries when no match #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inferno-chromium
requested changes
Feb 6, 2021
criticality_score/run.py
Outdated
| @property | ||
| def dependents_count(self): | ||
| # do query retries when no match to ensure accurate result | ||
| for i in range(FAIL_RETRIES): |
There was a problem hiding this comment.
We dont need two FAIL_RETRIES and a seperate function, can you modify the loop to not break on status 200. Break only when status is 200 and there is a match as well [and return directly from inside loop].
When we do search on related commits of specific repo_name in github, we perhaps get 200 status_code but no right page result, then get an unexpected 0 result accidently. This patch breaks retry loop only when result is 200 status with match result rather than only 200 status.
Yikun
changed the title
inferno-chromium
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do search on related commits of specific repo_name in github, we
perhaps get 200 status_code but no right page result, then get an
unexpected 0 result accidently.
This patch breaks retry loop only when result is 200 status with match
result rather than only 200 status.