Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump oss-fuzz #412

Closed
DavidKorczynski opened this issue Jul 25, 2022 · 13 comments
Closed

bump oss-fuzz #412

DavidKorczynski opened this issue Jul 25, 2022 · 13 comments

Comments

@DavidKorczynski
Copy link
Contributor

We should bump OSS-Fuzz as a reasonbly high number of changes has happened since last bump. There was a slight change in the way post-processing unit is called, so a few minor things need change in OSS-Fuzz besides bumping the LLVM number.

@Navidem @AdamKorcz do you have anything that you would like to complete before bumping on OSS-Fuzz side?

@DavidKorczynski
Copy link
Contributor Author

we actually dont have to update the diffs as they are mainly concerned with Python. So only very minor or no diffs are needed except for the commit bump

@Navidem
Copy link
Contributor

Navidem commented Jul 25, 2022

is the only change regarding post-process for OSS-Fuzz at this line?

python3 /fuzz-introspector/post-processing/main.py report $REPORT_ARGS

@Navidem
Copy link
Contributor

Navidem commented Jul 25, 2022

and this too:

python3 /fuzz-introspector/post-processing/main.py correlate --binaries_dir=$OUT/

@Navidem
Copy link
Contributor

Navidem commented Jul 25, 2022

re concerns on bump, I just wanted to have the bump after the summit as I will not be available to fix potential failures on OSS-Fuzz side.

@DavidKorczynski
Copy link
Contributor Author

I think so. All of the logic in compile_python_fuzzer is irrelevant right now, and all of the logic here

+ if [ "$FUZZING_LANGUAGE" = "python" ]; then
+ echo "GOING python route"
+ set -x
+ REPORT_ARGS="--target_dir=$SRC/inspector"
+ REPORT_ARGS="$REPORT_ARGS --language=python"
+ python3 /fuzz-introspector/src/main.py report $REPORT_ARGS
+ cp -rf $SRC/inspector $OUT/inspector
+ else
is also irrelevant and all of the logic for enabling python to be used with fuzz introspector is irrelevant.

I would say try the changes you suggest and if https://github.com/ossf/fuzz-introspector/tree/main/oss_fuzz_integration#testing-before-bumping-oss-fuzz passes then we're good

@DavidKorczynski
Copy link
Contributor Author

@AdamKorcz are there any UI leftovers that should be addressed before bumping on OSS-Fuzz?

@AdamKorcz
Copy link
Contributor

AdamKorcz commented Jul 25, 2022

@AdamKorcz are there any UI leftovers that should be addressed before bumping on OSS-Fuzz?

@DavidKorczynski There are the descriptions in the high-level overviews.
descriptions

@Navidem
Copy link
Contributor

Navidem commented Jul 25, 2022

I would say try the changes you suggest and if https://github.com/ossf/fuzz-introspector/tree/main/oss_fuzz_integration#testing-before-bumping-oss-fuzz passes then we're good

let's have #411 merged, then I can test.

@DavidKorczynski
Copy link
Contributor Author

DavidKorczynski commented Jul 26, 2022

@DavidKorczynski There are the descriptions in the high-level overviews.

ah yes. I think this one would be quite nice to complete. I will do this today.

@DavidKorczynski
Copy link
Contributor Author

Note that test_projects.py will fail for wuffs as wuffs build is currently failing: https://oss-fuzz-build-logs.storage.googleapis.com/log-9aaac143-2250-4fd2-b86b-61e178eae971.txt

DavidKorczynski added a commit to google/oss-fuzz that referenced this issue Jul 26, 2022
Existing corpus link is no longer accessible. Switching to a reliable source.

Fixing this also to unbreak Fuzz Introspector tests here ossf/fuzz-introspector#412 (comment)
@DavidKorczynski
Copy link
Contributor Author

@DavidKorczynski There are the descriptions in the high-level overviews.

ah yes. I think this one would be quite nice to complete. I will do this today.

This is now done. I'm good with bumping on OSS-Fuzz now.

@Navidem
Copy link
Contributor

Navidem commented Jul 26, 2022

Test for could build is remaining, I will be slow to respond for the rest of the week, attending a team summit.

jonathanmetzman pushed a commit to google/oss-fuzz that referenced this issue Jul 26, 2022
Existing corpus link is no longer accessible. Switching to a reliable source.

Fixing this also to unbreak Fuzz Introspector tests here ossf/fuzz-introspector#412 (comment)
@Navidem
Copy link
Contributor

Navidem commented Aug 1, 2022

Done via google/oss-fuzz#8078

@Navidem Navidem closed this as completed Aug 1, 2022
henryrneh pushed a commit to CodeIntelligenceTesting/oss-fuzz that referenced this issue Aug 1, 2022
Existing corpus link is no longer accessible. Switching to a reliable source.

Fixing this also to unbreak Fuzz Introspector tests here ossf/fuzz-introspector#412 (comment)
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this issue Aug 15, 2022
Existing corpus link is no longer accessible. Switching to a reliable source.

Fixing this also to unbreak Fuzz Introspector tests here ossf/fuzz-introspector#412 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants