Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort table by source code lines #54

Merged
merged 1 commit into from Mar 2, 2022
Merged

Conversation

AdamKorcz
Copy link
Contributor

If a table has the column "source code lines" it will sort by that table descending.

Closes #45

@DavidKorczynski
Copy link
Contributor

Very nice!

We can get this in now, but, would it be possible to make it more general such that we can indicate which column is the sortable one when creating the HTML table in the python code, for example as an argument to this function:

def create_table_head(table_head: str, items: List[str]) -> str:

@AdamKorcz
Copy link
Contributor Author

We can get this in now, but, would it be possible to make it more general such that we can indicate which column is the sortable one when creating the HTML table in the python code, for example as an argument to this function:

Sure, will look into that.

@DavidKorczynski DavidKorczynski merged commit acdd108 into ossf:main Mar 2, 2022
@DavidKorczynski DavidKorczynski mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve default sort order of tables
2 participants